Some reorganize and clean up #2
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
balancy
reviewed
Sep 24, 2023
| return registration_data_factory() | ||
|
|
||
|
|
||
| @pytest.mark.parametrize('page', [ |
There was a problem hiding this comment.
советуют физические пути к url заменять на конструкции reverse('identity:login"), т.к. лучше привизываться к именам, а не к hardcoded путям. Так тесты становятся менее хрупкими
balancy
reviewed
Sep 24, 2023
| def pytest_configure(config: pytest.Config) -> None: | ||
| """Create or restore random value to be used as seed during tests.""" | ||
| seed_value = config.getoption('randomly_seed') | ||
| default_seed = random.Random().getrandbits(random_seed) |
There was a problem hiding this comment.
не очень логично называть переменную, которую ты используешь в качестве размерности сгенерированного случайного числа, random_seed, т.к. seed у тебя вычисляется дальше. Можно было назвать как-нибудь типа random_seed_length
|
Я полазил посмотрел по коду, стало интересно, откуда в этой фикстуре @pytest.fixture()
def user_data_factory(field: Field) -> UserDataFactory:приходит |
teddybear
reviewed
Sep 24, 2023
|
|
||
|
|
||
| @pytest.fixture(scope='session') | ||
| def field() -> Field: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Переход к домашке второй недели:
Сделала пул реквест чтобы не забыть до дедлайна, ушла обратно делать вторую домашку
Если будут значительные апдейты по домашке - добавлю в список)