Fix payer proofs to match latest spec#9144
Open
rustyrussell wants to merge 4 commits into
Open
Conversation
It's now optional, so make it NULL here. Reported-by: @t-bast Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Calculate proof_merkle_root properly: we accidentally printed the `invoice_merkle_root` again here. Reported-by: @t-bast. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Spec simplification suggested by @t-bast. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(This is experimental, so can slip into the release process if needed during RCs).
This matches the latest spec, and @t-bast confirmed they agree with the test vectors! FULL STEAM AHEAD
Changelog-None: it's experimental already, and new in this release.