Skip to content

Improving currencyrate plugin#9011

Open
enaples wants to merge 4 commits intoElementsProject:masterfrom
enaples:improve-currencyrate-plugin
Open

Improving currencyrate plugin#9011
enaples wants to merge 4 commits intoElementsProject:masterfrom
enaples:improve-currencyrate-plugin

Conversation

@enaples
Copy link
Copy Markdown
Collaborator

@enaples enaples commented Mar 31, 2026

Important

26.04 FREEZE March 11th: Non-bugfix PRs not ready by this date will wait for 26.06.

RC1 is scheduled on March 23rd

The final release is scheduled for April 15th.

Checklist

Before submitting the PR, ensure the following tasks are completed. If an item is not applicable to your PR, please mark it as checked:

  • The changelog has been updated in the relevant commit(s) according to the guidelines.
  • Tests have been added or modified to reflect the changes.
  • Documentation has been reviewed and updated as needed.
  • Related issues have been listed and linked, including any that this PR closes.
  • Important All PRs must consider how to reverse any persistent changes for tools/lightning-downgrade

Currencyrate plugin changes

As mentioned in #9010,

  1. Check on RPC argument number added
  2. Show max three decimal digits
  3. Added source argument to the currencyrate RPC call
  4. Added "Example" on RPC documentation

Info Needed

I would personally suggest to add a README.md file in the currencyrate plugin folder reporting how to configure new sources in the config file, plus some best practice using reckless to add and disable sources without restarting the node.

@enaples enaples requested a review from daywalker90 March 31, 2026 15:11
@enaples enaples added this to the 26.06 milestone Mar 31, 2026
@enaples enaples changed the title plugin: round to the tird digit and adding source argument to `curren… Improving currencyrate plugin Mar 31, 2026
@enaples enaples linked an issue Mar 31, 2026 that may be closed by this pull request
@madelinevibes madelinevibes added the 26.04 RC This PR needs to go into the next release candidate for 26.04 label Mar 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

26.04 RC This PR needs to go into the next release candidate for 26.04

Projects

None yet

Development

Successfully merging this pull request may close these issues.

currencyrate plugin UI improvement proposals

2 participants