Fix injectpaymentonion fees#9008
Open
Lagrang3 wants to merge 4 commits intoElementsProject:masterfrom
Open
Conversation
0e0bfdc to
30fc0d9
Compare
Changelog-None Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
3f2ad53 to
ad44228
Compare
Changelog-Fixed: injectpayment_onion: fix fees for blinded paths, treat amount_msat as the incoming amount and not the forward amount. Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
ad44228 to
8b80ed8
Compare
Changelog-None Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
36ed233 to
da14a54
Compare
Collaborator
Author
|
At this point da14a54 we don't need |
Changelog-None Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes issue #9006.
According to the description of
injectpaymentonionthis command simulates an incoming htlc from a peer.The onion to us contains the information to deduce the next hop.
To be consistent with this this description, the command parameter
amount_msatshould correspond to theamount the peer has provided to us and not the amount we should forward to our next peer.
The intention is deduced from this statement
msatis theamount_msatparameter from the RPC, therefore is interpreted as theamount_in.We did not see this before because we were using
auto.sourcefreelayer.