reckless: fail reckless rpc if executable fails#8894
Open
Lagrang3 wants to merge 1 commit intoElementsProject:masterfrom
Open
reckless: fail reckless rpc if executable fails#8894Lagrang3 wants to merge 1 commit intoElementsProject:masterfrom
Lagrang3 wants to merge 1 commit intoElementsProject:masterfrom
Conversation
If the execution of reckless fails for some reason recklessrpc plugin should return an rpc failure message instead of hanging. Changelog-None. Signed-off-by: Lagrang3 <lagrang3@protonmail.com>
Member
|
ACK 1b46d01 |
cdecker
approved these changes
Feb 12, 2026
Collaborator
|
ACK 1b46d01 |
rustyrussell
requested changes
Feb 13, 2026
Contributor
rustyrussell
left a comment
rustyrussell
left a comment
There was a problem hiding this comment.
I think this deserves a Changelog-Fixed: JSON-RPC: reckless command no longer hangs if the reckless command is not found.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the execution of reckless fails for some reason recklessrpc plugin should return an rpc failure message instead of hanging.
This can happen for example if reckless executable is not found the the environment PATH.