Make all peer messages constant message size#8893
Open
rustyrussell wants to merge 11 commits intoElementsProject:masterfrom
Open
Make all peer messages constant message size#8893rustyrussell wants to merge 11 commits intoElementsProject:masterfrom
rustyrussell wants to merge 11 commits intoElementsProject:masterfrom
Conversation
rustyrussell
force-pushed
the
guilt/constant-message-size
branch
10 times, most recently
from
50d3283 to
c949301
Compare
This requires access to dumpcap. On Ubuntu, at least, this means you need to be in the "wireshark" group. We may also need: sudo ethtool -K lo gro off gso off tso off Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Give us a single "next message" function to call. This will be useful when we want to write more than one at a time. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Do all the special treatment of the message type first. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This gives us finer control over write sizes: for now we just cap the write size. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
We're doing our own buffering now. We leave the is_urgent() function for two commits in the future though. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
… count. We are about to use them to make our packet size constant, and this will upset the tests. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
Messages are now constant. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au> Changelog-Added: Protocol: we now pad all peer messages to make them the same length.
This replaces our previous nagle-based toggling. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
…ges. Since we delay the others quite a lot (up to 1 second), it's better to consider most messages "urgent" and worth immediately transmitting. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
This is exactly what membuf is for: it handles expansion much more neatly. Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
rustyrussell
force-pushed
the
guilt/constant-message-size
branch
from
c949301 to
5132083
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not sufficient, but definitely necessary for avoiding trivial observation.