Fix bkpr emergency recover crash#8890
Open
rustyrussell wants to merge 2 commits intoElementsProject:masterfrom
Open
Fix bkpr emergency recover crash#8890rustyrussell wants to merge 2 commits intoElementsProject:masterfrom
rustyrussell wants to merge 2 commits intoElementsProject:masterfrom
Conversation
Signed-off-by: Rusty Russell <rusty@rustcorp.com.au>
We can't really do decent bookkeeping any more, but don't crash! ``` bookkeeper: plugins/bkpr/recorder.c:178: find_txo_chain: Assertion `acct->open_event_db_id' failed. bookkeeper: FATAL SIGNAL 6 (version v25.12) 0xaaaab7d51a7f send_backtrace common/daemon.c:38 0xaaaab7d51b2b crashdump common/daemon.c:83 0xffff8c0b07cf ??? ???:0 0xffff8bdf7608 __pthread_kill_implementation ./nptl/pthread_kill.c:44 0xffff8bdacb3b __GI_raise ../sysdeps/posix/raise.c:26 0xffff8bd97dff __GI_abort ./stdlib/abort.c:79 0xffff8bda5cbf __assert_fail_base ./assert/assert.c:96 0xffff8bda5d2f __assert_fail ./assert/assert.c:105 0xaaaab7d41fd7 find_txo_chain plugins/bkpr/recorder.c:178 0xaaaab7d421fb account_onchain_closeheight plugins/bkpr/recorder.c:291 0xaaaab7d37687 do_account_close_checks plugins/bkpr/bookkeeper.c:884 0xaaaab7d38203 parse_and_log_chain_move plugins/bkpr/bookkeeper.c:1261 0xaaaab7d3871f listchainmoves_done plugins/bkpr/bookkeeper.c:171 0xaaaab7d4811f handle_rpc_reply plugins/libplugin.c:1073 0xaaaab7d4827b rpc_conn_read_response plugins/libplugin.c:1377 0xaaaab7d889a7 next_plan ccan/ccan/io/io.c:60 0xaaaab7d88f7b do_plan ccan/ccan/io/io.c:422 0xaaaab7d89053 io_ready ccan/ccan/io/io.c:439 ``` Fixes: ElementsProject#8854 Changelog-Fixed: Plugins: `bkpr_listbalances` no longer crashes if we lost our db, then do emergencyrecover and close a channel. Reported-by: https://github.com/enaples
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.