fix(platform): return 499 instead of 503 when client disconnects during nested fiber execution #5969
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #5968
causeResponseto pre-compute whetherclientAbortFiberIdexists anywhere in the cause tree before traversing individual interrupt nodesThe Bug
In
causeResponse, the original code checkedcause.fiberId === clientAbortFiberIdon each interrupt node duringCause.reducetraversal. This fails when the cause tree has a structure like:Because
Cause.reducevisits the left branch first, it encountersparentFiberIdbeforeclientAbortFiberIdand incorrectly returns 503.The Fix
Pre-compute whether
clientAbortFiberIdexists anywhere in the cause tree usingCause.interruptors()before entering the reduce loop:Then use this flag when handling interrupt nodes instead of checking the individual node's fiber ID.
Test
The test constructs a synthetic cause that mimics the problematic structure:
Note: Effect's runtime properly propagates interrupt IDs to child fibers, so real HTTP tests with nested fibers don't reproduce this specific cause structure. The synthetic test directly exercises
causeResponsewith the problematic cause tree.