Added modules for IndexedDb#1240
Conversation
|
A few adjustments are still needed for the v4 migrations. @tim-smart what's the @gcanti |
lewxdev
left a comment
There was a problem hiding this comment.
This is a non-exhaustive feedback on the current changes.
@tim-smart please feel free to review these comments before @SandroMaglione makes any changes
There was a problem hiding this comment.
IndexedDB is effectively a NoSQL database, and I think using vocabulary like "Table" is incorrect. This module would be more accurate renamed to IndexedDbObjectStore. ("Table" makes sense if you have columns)
Note that the "Table" vocabulary is also used throughout and should be updated as well.
There was a problem hiding this comment.
Correct me if I'm wrong, but with the current implementation it's not possible to create an index or key on a deeply nested field.
This is a big limitation that could be addressed by taking an annotation-driven approach to defining ObjectStore schemas (although this may not work well with the query builder unless some TypeScript wizardry is employed, but maybe that's an okay tradeoff).
|
This API is fascinating. A few thoughts:
|
🦋 Changeset detectedLatest commit: a90cd6c The changes in this PR will be included in the next version bump. This PR includes changesets to release 26 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
@tim-smart I updated the implementation to v4 (typed ids, effect/yieldable encoding, schema and apis). All the tests are now passing. What's the next step to move this forward? |
47c1d56 to
ae53dcd
Compare
📊 JSDoc Documentation Analysis📈 Current Analysis ResultsThis comment is automatically updated on each push. View the analysis script for details. |
Bundle Size Analysis
|
Type
Description
Porting of the
IndexedDbPR from v3 to v4 (original source).