Open
Conversation
swansontec
approved these changes
Jul 2, 2025
Comment on lines
+245
to
+253
| /** | ||
| * Get the private view key for a wallet. | ||
| * This key allows viewing incoming transactions without spending ability. | ||
| * WARNING: This is sensitive information - handle with care! | ||
| */ | ||
| async getPrivateViewKey(walletId: number): Promise<string> { | ||
| const walletInfo = await this.getWalletInfo(walletId) | ||
| return walletInfo.wi_extended.view_private_key | ||
| } |
Contributor
There was a problem hiding this comment.
Not sure if we even need this PR at all, since getWalletInfo already exists, and is accessible from the JS world. Couldn't the PoS app do these two lines just as well?
This seems like a documentation problem, not a code problem. If we had type definitions for the getWalletInfo return value, we could just put a /** Private view key */comment in the right place, and call it good.
Contributor
There was a problem hiding this comment.
Move this method to EdgeCurrencyTools in accountbased.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.