Change log naming convention#12
Open
brysonak wants to merge 1 commit into
Open
Conversation
Changed log naming from "[r14(server)]-[MM-DD-YYYY]_[HH-MM-SS]_N" to "nevr-server-YYYYMMDD-HHMMSS"
|
Clean approach — hooking CreateFileA to intercept the log path is clever. The sortable timestamp format will make log analysis way easier. Good call including the legacy flag for backwards compat. |
Member
Author
|
note a possible edge case for any future problems: if multiple logs open in the same second, one may overwrite or fail depending on |
Member
Author
|
@metis-sprock can you merge this PR into |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed log naming from "[r14(server)]-[MM-DD-YYYY]_[HH-MM-SS]_N" to "nevr-server-YYYYMMDD-HHMMSS"
Also added
-legacy-log-namesflag to allow the old naming convention of logs to be used.Fixes #5