Skip to content

Encounter rate: Fix off-by-one error#3542

Merged
carstene1ns merged 1 commit into
EasyRPG:masterfrom
Ghabry:issue-2903
May 14, 2026
Merged

Encounter rate: Fix off-by-one error#3542
carstene1ns merged 1 commit into
EasyRPG:masterfrom
Ghabry:issue-2903

Conversation

@Ghabry
Copy link
Copy Markdown
Member

@Ghabry Ghabry commented May 3, 2026

Honestly not sure if this is 100% correct but it "feels" at least closer to RPG2k3 now when testing.

What matches:

  • With EncRate 1 you get a forced encounter (before it was 2)
  • With 2 a forced after 2 (before it was 3)

Higher numbers are harder to test due to randomness involved.

Fix #2903

Not sure if this is 100% correct but it "feels" at least closer to RPG2k3 now when testing.

What matches:
- With EncRate 1 you get a forced encounter (before it was 2)
- With 2 a forced after 2 (before it was 3)

Higher numbers are harder to test due to randomness involved.

Fix EasyRPG#2903
@Mimigris
Copy link
Copy Markdown
Contributor

Mimigris commented May 8, 2026

Just tested and it indeed seems closer to RPG_RT now 👍
Once again, it's a bit hard to truly compare due to the RNG involved, but it at seems more in line at the very least.
(only thing I noticed when checking is that negative encounter rates aren't handled in the same way between both engines, but as there is no real purpose in doing so and that the default engine does not allow you in any way to do it, it's not like it is a big deal)

@Ghabry Ghabry marked this pull request as ready for review May 9, 2026 00:00
@carstene1ns carstene1ns merged commit db99f63 into EasyRPG:master May 14, 2026
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants