Skip to content

Fix incorrect references to non-existent AdvancedOptions class#86

Merged
Justintime50 merged 1 commit intoEasyPost:masterfrom
GUI:master
Mar 9, 2026
Merged

Fix incorrect references to non-existent AdvancedOptions class#86
Justintime50 merged 1 commit intoEasyPost:masterfrom
GUI:master

Conversation

@GUI
Copy link
Contributor

@GUI GUI commented Mar 8, 2026

Description

These references in the README should refer to AdvancedSettings instead. The subsequent calls in the README to HttpClients.NewHttpClient already were passing in a advancedSettings variable, so this lets these examples work.

Testing

N/A

Pull Request Type

Please select the option(s) that are relevant to this PR.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement (fixing a typo, updating readme, renaming a variable name, etc)

These references in the README should refer to `AdvancedSettings`
instead. The subsequent calls in the README to
`HttpClients.NewHttpClient` already were passing in a `advancedSettings`
variable, so this lets these examples work.
@GUI GUI requested review from a team as code owners March 8, 2026 01:53
Copy link
Member

@Justintime50 Justintime50 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the correction! 😃

@Justintime50 Justintime50 merged commit fb03351 into EasyPost:master Mar 9, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants