Fix filters for Doctrine embedded class fields#4840
Closed
Ang3 wants to merge 15 commits intoEasyCorp:masterfrom
Ang3:feature_filter_embedded_property
Closed
Fix filters for Doctrine embedded class fields#4840Ang3 wants to merge 15 commits intoEasyCorp:masterfrom Ang3:feature_filter_embedded_property
Ang3 wants to merge 15 commits intoEasyCorp:masterfrom
Ang3:feature_filter_embedded_property
Conversation
Ang3
changed the title
Ang3
changed the title
Ang3
changed the title
Simplify handling
Contributor
Author
|
No reply and pull request #4882 inserted into the milestone 4.x. I think a nested filter is not an efficient way because it breaks the logic of filters : it takes care about embedded class properties (mixed type) AND associations (the aim of the entity filter). Nevermind, the most important is to be able to use filters on embedded Doctrine classes: a very very very primary feature and without discuss about. |
Contributor
|
Geat work! 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4245
Explanations
This fix replaces dots by underscore internally in the form and filters collection without change anything else.
Limitations
foo.bar(embedded) andfoo_bar(not embedded), you might have some troubles.