Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[1.0.12] — 2026-03-05
Fixed
RefinedDivider,QTextEdit,QScrollArea, andhover-state widgets emitted Qt warnings
Could not parse stylesheet.Root cause: closing
}}in plain (non-f) string literals was passed literally tothe CSS parser instead of being collapsed to
}.Fixed 7 occurrences across
RefinedDivider.__init__,_create_log_panel,RefinedFolderDialog.__init__, andon_file_item_hover.Security
import xml.etree.ElementTree as ETwith
import defusedxml.ElementTree as ETacross all XML parsing calls(
TranslationManager.load_language,get_language_name_from_xml).The standard library parser is vulnerable to Billion Laughs and XXE attacks
(CWE-20);
defusedxmlmitigates both.except: passblocks with explicit error handling:
get_language_name_from_xml— prints a warning with filename and exception messageUniversalPEPatcher.patch_allIAT fallthrough — emitslog_iat_parse_failedvialog_emitterFileProcessorWorker.runPE metadata read — prints a warning with exception messageCode Quality
too-many-lines— added module-level disable (2 400-line single-file GUI is anaccepted constraint)
attribute-defined-outside-init× 27 — pre-declared all 27PEPatcherGUIUIattributes as
Nonein__init__beforesetup_ui()callredefined-outer-name× 8 — renamed shadowing parameters:lang_code→language_code/file_lang_code/selected_code,show_dialog→show_again,translator→trtoo-many-nested-blocks— extracted IAT scanning logic frompatch_allinto twohelpers:
_apply_iat_replacements()and_scan_iat_entries(), reducing nesting from9 to ≤ 5 levels
invalid-name× 4 — added method-level disables for Qt-mandated camelCase eventoverrides (
mousePressEvent,mouseMoveEvent,mouseReleaseEvent,closeEvent)too-few-public-methods× 6 — added class-level disables for intentionally minimalQt signal/widget subclasses (
PatcherLogEmitter,FileProcessorWorker,RefinedContainer,RefinedSplitter,RefinedDivider,AboutDialog)too-many-instance-attributes× 3 — added class-level disables forSwipeableFileItem,RefinedFolderDialog,PEPatcherGUItoo-many-*(statements/locals/branches) × 7 — added method-level disables forpatch_all,PatcherWorker.run,LanguageDialog.__init__,SwipeableFileItem.__init__,RefinedFolderDialog.__init__,setup_ui,_create_settings_panel,AboutDialog.setup_ui,patching_donetoo-many-public-methods— added class-level disable forPEPatcherGUIc-extension-no-member— added inline disable forlief.PE.MACHINE_TYPES.AMD64line-too-long(CSS block) — wrappedREFINED_STYLESHEETwithpylint: disable/enable=line-too-long; added inline disable for Monero address(hash is immutable)
wrong-import-order— movedglobbefore third-party imports; moveddefusedxmlinto the third-party block alongside
liefmissing-final-newline— added trailing newline at EOFDependencies
defusedxmltorequirements.txtTooling
run.sh— Unix equivalent ofrun.bat: creates venv, installs dependencies,launches
main.py