-
Notifications
You must be signed in to change notification settings - Fork 219
Fixes rpointer archiving #4907
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Fixes rpointer archiving #4907
Conversation
jedwards4b
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest removing the three unused routines:
get_entries
get_entry_info
get_rpointer_contents.
|
|
||
| yield file, content | ||
|
|
||
| # TODO check if used otherwise remove |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could not find any usage of any of get_entries, get_entry_info or get_rpointer_contents in CESM.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could not find any usage either, I'll go ahead and remove them.
|
Regarding the test failures I found that a check of the object 'archive' at line 200 of case_st_archive.py |
jedwards4b
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Running case.st_archive --test-all reveals a problem with your new code. The
archive variable is of type Archive and not env_archive as you expect.
|
@jedwards4b Thanks, I see the issue. I'll adjust the code and have you review again. |
Description
When using the
--copy-onlyor--last_dateoption, the latest rpointer files would be moved from the run directory breaking the ability to restart a run. The first archived rpointer file would be incorrect as CIME would move the current rpointer into the archive directory and then create all subsequent rpointer files (these would be correct).Checklist