Accept polygon-vertex bounds in VAR004 shape check#38
Open
JanStreffing wants to merge 1 commit into
Open
Conversation
CF 1.11 §7.1 allows interval bounds (n, 2) *or* polygon-vertex bounds (n, m) with m >= 2 for unstructured grids where each cell is a polygon. The previous shape check hard-rejected any m != 2, producing mandatory VAR004 failures on otherwise-compliant FESOM2 / ICON / MPAS output where lat_bnds/lon_bnds carry polygon vertex coordinates. Relax the shape check to require shape[1] >= 2. Applied to both CMIP6 and CMIP7 plugin paths to keep them in sync.
Author
|
Any updates on this review? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CF 1.11 §7.1 allows interval bounds (n, 2) or polygon-vertex bounds (n, m) with m >= 2 for unstructured grids where each cell is a polygon. The previous shape check hard-rejected any m != 2, producing mandatory VAR004 failures on otherwise-compliant FESOM2 / ICON / MPAS output where lat_bnds/lon_bnds carry polygon vertex coordinates.
Relax the shape check to require shape[1] >= 2. Applied to both CMIP6 and CMIP7 plugin paths to keep them in sync.