Open
Conversation
Member
Author
|
@iangrooms Just a quick note, I added |
iangrooms
reviewed
Apr 3, 2026
Collaborator
There was a problem hiding this comment.
In my issue I listed Ahh, Khh, KHTH_t, and KHTR_h. Those are the MOM6 names, but I think they have CMOR names. Should we put the CMOR names here? The CMOR equivalents are
Ahh = difmxybo
Khh = difmxylo
KHTH_t = diftrblo
KHTR_h = diftelo
Also, we are using Leith+E backscatter by default, so we should save the coefficient BS_coeff_h in the native file.
iangrooms
reviewed
Apr 3, 2026
Collaborator
There was a problem hiding this comment.
Same comment as for diag_table.json about the CMOR names and BS_coeff_h.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the diag table changes listed in #308
Testing: GW_JRA.TL319_t232, B1850C_LTso.ne30_t232