Open
Conversation
mkavulich
requested review from
MarekWlasak,
cacraigucar,
climbfuji,
dustinswales,
gold2718,
grantfirl,
mwaxmonsky,
nusbaume,
peverwhee,
ss421 and
svahl991
as code owners
climbfuji
requested changes
Feb 13, 2026
Metadata-standard-names.md
Outdated
| * `ccpp_thread_number`: Number of current OpenMP thread. This variable may only be used during CCPP run phase | ||
| * `integer`: units = index | ||
| * `number_of_ccpp_instances`: Number of parallel CCPP instances | ||
| * `integer`: units = index |
Collaborator
There was a problem hiding this comment.
Suggested change
| * `integer`: units = index | |
| * `integer`: units = count |
I think this must be count.
Collaborator
Author
There was a problem hiding this comment.
Thanks for catching this, done.
gold2718
approved these changes
Feb 14, 2026
Collaborator
gold2718
left a comment
gold2718
left a comment
There was a problem hiding this comment.
This is okay but I have a suggested clarification for one description.
| <type units="index">integer</type> | ||
| </standard_name> | ||
| <standard_name name="number_of_ccpp_instances" | ||
| description="Number of parallel CCPP instances"> |
Collaborator
There was a problem hiding this comment.
This is okay but I suggest distinguishing this case from other ensemble methods:
Suggested change
| description="Number of parallel CCPP instances"> | |
| description="Number of parallel CCPP instances on this MPI task"> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adding names for CCPP instances,
number_of_ccpp_instancesandccpp_instance_number.@climbfuji @gold2718 If you have suggestions for better/more detailed descriptions please let me know.
Issues
Resolves #133