-
Notifications
You must be signed in to change notification settings - Fork 18
Change units and description for number fraction of dust aerosol in GLOMAP/UKCA #114
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
f694bbd
fix units for glomap number concentration
mo-hlawrence 532892d
change the units and description for number fractions of dust in GLOMAP
mo-hlawrence 4d4ce45
Merge branch 'main' into feature/fix_glomap_units
mkavulich 1a48b60
Merge branch 'main' into feature/fix_glomap_units
mkavulich 21fa145
Update new standard names yaml
mkavulich File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -797,12 +797,12 @@ | |||||
| <type kind="kind_phys" units="kg kg-1">real</type> | ||||||
| </standard_name> | ||||||
| <standard_name name="number_fraction_of_coarse_aerosol_particles_in_air" | ||||||
| long_name="Number fraction of coarse mode dust aerosol particles"> | ||||||
| <type kind="kind_phys" units="1">real</type> | ||||||
| long_name="Ratio of number concentration of coarse mode dust aerosol particles to the molecular concentration of air"> | ||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| <type kind="kind_phys" units="particles molecules-1">real</type> | ||||||
| </standard_name> | ||||||
| <standard_name name="number_fraction_of_accumulation_aerosol_particles_in_air" | ||||||
| long_name="Number fraction of accumulation mode dust aerosol particles"> | ||||||
| <type kind="kind_phys" units="1">real</type> | ||||||
| long_name="Ratio of number concentration of accumulation mode dust aerosol particles to the molecular concentration of air"> | ||||||
|
Collaborator
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
|
||||||
| <type kind="kind_phys" units="particles molecules-1">real</type> | ||||||
| </standard_name> | ||||||
| </section> | ||||||
| <section name="emissions" | ||||||
|
|
||||||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.