Add FATES tree recruitment scheme tests #3757
Draft
glemieux wants to merge 5 commits intoESCOMP:b4b-devfrom
Draft
Add FATES tree recruitment scheme tests #3757glemieux wants to merge 5 commits intoESCOMP:b4b-devfrom
glemieux wants to merge 5 commits intoESCOMP:b4b-devfrom
Conversation
Collaborator
Author
|
Running the TRS test mods on |
Collaborator
Author
|
The Alternatively, we could attempt to fix the issue and turn this PR into an API update associated with whichever FATES tag fixes the TRS issue. |
Collaborator
Author
|
TO DO:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
This simple pull request adds the two recruitment namelist options for the FATES tree recruitment scheme. There are two different modes for turning on the scheme, which now have a test. No FATES parameter file modifications are necessary to activate the test.
Resolves #2760.
Note that there is an known FATES mass balance issue, NGEET/fates#1246, that might be triggered by the
FatesColdTRStestmod. This will be added to the expected fail list if it comes up during testing.Specific notes
Contributors other than yourself, if any:
CTSM Issues Fixed (include github issue #): #2760
Are answers expected to change (and if so in what way)? No
Any User Interface Changes (namelist or namelist defaults changes)? No
Does this create a need to change or add documentation? Did you do so? No
Testing performed, if any:
(List what testing you did to show your changes worked as expected)
(This can be manual testing or running of the different test suites)
(Documentation on system testing is here: https://github.com/ESCOMP/ctsm/wiki/System-Testing-Guide)
(aux_clm on derecho for intel/gnu and izumi for intel/gnu/nag/nvhpc is the standard for tags on master)
NOTE: Be sure to check your coding style against the standard
(https://github.com/ESCOMP/ctsm/wiki/CTSM-coding-guidelines) and review
the list of common problems to watch out for
(https://github.com/ESCOMP/CTSM/wiki/List-of-common-problems).