Skip to content

Add FATES tree recruitment scheme tests #3757

Draft
glemieux wants to merge 5 commits intoESCOMP:b4b-devfrom
glemieux:fates-tests-trs
Draft

Add FATES tree recruitment scheme tests #3757
glemieux wants to merge 5 commits intoESCOMP:b4b-devfrom
glemieux:fates-tests-trs

Conversation

@glemieux
Copy link
Collaborator

@glemieux glemieux commented Feb 12, 2026

Description of changes

This simple pull request adds the two recruitment namelist options for the FATES tree recruitment scheme. There are two different modes for turning on the scheme, which now have a test. No FATES parameter file modifications are necessary to activate the test.

Resolves #2760.

Note that there is an known FATES mass balance issue, NGEET/fates#1246, that might be triggered by the FatesColdTRS testmod. This will be added to the expected fail list if it comes up during testing.

Specific notes

Contributors other than yourself, if any:

CTSM Issues Fixed (include github issue #): #2760

Are answers expected to change (and if so in what way)? No

Any User Interface Changes (namelist or namelist defaults changes)? No

Does this create a need to change or add documentation? Did you do so? No

Testing performed, if any:
(List what testing you did to show your changes worked as expected)
(This can be manual testing or running of the different test suites)
(Documentation on system testing is here: https://github.com/ESCOMP/ctsm/wiki/System-Testing-Guide)
(aux_clm on derecho for intel/gnu and izumi for intel/gnu/nag/nvhpc is the standard for tags on master)

NOTE: Be sure to check your coding style against the standard
(https://github.com/ESCOMP/ctsm/wiki/CTSM-coding-guidelines) and review
the list of common problems to watch out for
(https://github.com/ESCOMP/CTSM/wiki/List-of-common-problems).

@glemieux glemieux requested a review from rgknox February 12, 2026 18:36
@glemieux
Copy link
Collaborator Author

Running the TRS test mods on derecho currently.

@glemieux glemieux marked this pull request as draft February 12, 2026 19:15
@glemieux
Copy link
Collaborator Author

glemieux commented Feb 12, 2026

The FatesColdTRSNoSeedDynamics runs successfully, but the FatesColdTRS test mod is failing with an issue different from NGEET/fates#1246. I'll create a new issue on the fates side and update the expected failure list.

Alternatively, we could attempt to fix the issue and turn this PR into an API update associated with whichever FATES tag fixes the TRS issue.

@glemieux
Copy link
Collaborator Author

glemieux commented Feb 12, 2026

TO DO:

  • Review history output to add to test
  • Add expected failure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant