post5.4: Use the correct C13/C14 atm ratio in the code more#3632
post5.4: Use the correct C13/C14 atm ratio in the code more#3632ekluzek wants to merge 2 commits intoESCOMP:masterfrom
Conversation
… in place of preindustrial values in the code from issue ESCOMP#3567
ekluzek
added
science
|
I can review this, Erik. We may be more productive going through this together, or doing a functional test of the code (historical simulation) to see if things look as expected? |
ekluzek
changed the title
|
| c13_cnveg_carbonstate_inst%totvegc_patch(p) / cnveg_carbonstate_inst%totvegc_patch(p) | ||
| else | ||
| c13_cnveg_carbonstate_inst%leafc_xfer_patch(p) = leafc_xfer(p) * c13ratio | ||
| c13_cnveg_carbonstate_inst%leafc_xfer_patch(p) = leafc_xfer(p) * rc13_atm |
There was a problem hiding this comment.
This is only called if totvegC <0? I don't really understand how you can have leaf transfer C pool if totvegc is negative?
| c14_cnveg_carbonstate_inst%totvegc_patch(p) / cnveg_carbonstate_inst%totvegc_patch(p) | ||
| else | ||
| c14_cnveg_carbonstate_inst%leafc_xfer_patch(p) = leafc_xfer(p) * c14ratio | ||
| ! TODO: This should use the proper gridcell values rather than the global average |
There was a problem hiding this comment.
As above, I'm not really clear when / why this would be called?
| cs_soil%decomp0_cpools_vr_col = epsi | ||
| end where | ||
| if(use_c13)then | ||
| ! Does the c3_r2 here need to change? |
There was a problem hiding this comment.
This seems confusing, since c3_r2 is the "isotope ratio (13c/[12c+13c]) for C3 photosynthesis". This would ignore contribution from the 13C isotopic signature of C4 photosynthesis (c4_r2) to soil C pools?
There was a problem hiding this comment.
That said, this is also only called when decomp0_cpools_vr_col is a small number. Is this just for numerica stability?
3 participants
Description of changes
This brings in changes to use the correct C13/C134 atmospheric ratio more. I need a scientist working in the C13/C14 space to review this.
Specific notes
Contributors other than yourself, if any:
CTSM Issues Fixed (include github issue #):
Fixes #3567
Are answers expected to change (and if so in what way)? Yes, when C13/C14 on for BGC simulations
Any User Interface Changes (namelist or namelist defaults changes)? No No
Does this create a need to change or add documentation? Did you do so? No No
Testing performed, if any: Limited so far