ctsm5.3.069: Add SystemTests to run subset_data and then CTSM#3292
Merged
samsrabin merged 19 commits intoESCOMP:masterfrom Aug 12, 2025
Merged
ctsm5.3.069: Add SystemTests to run subset_data and then CTSM#3292samsrabin merged 19 commits intoESCOMP:masterfrom
samsrabin merged 19 commits intoESCOMP:masterfrom
Conversation
2 tasks
Runs the subset_data point tool, then runs CTSM with the outputs.
Runs subset_data region tool to extract a six-gridcell region, then runs CTSM on the outputs.
b2c3176 to
c4604b8
Compare
samsrabin
commented
Jul 3, 2025
samsrabin
commented
Jul 3, 2025
slevis-lmwg
approved these changes
Jul 3, 2025
Contributor
slevis-lmwg
left a comment
There was a problem hiding this comment.
@samsrabin and I went over this PR together:
- @samsrabin posted a few TODOs
- I posted a question that I missed during the paired review
- I am approving the PR preemptively
This was causing failure in SETUP phase when generating baselines for the SUBSETDATA SystemTests.
Member
Author
|
Turns out that the SUBSETDATA tests don't work when trying to generate baselines. See ESMCI/cime#4819, which fixes the problem, but now serves as a blocker for this PR. |
Member
Author
|
No longer blocked by CIME; bring in tag cime6.1.112. |
Member
Author
|
Merging into master instead of b4b-dev because this depends on CIME updates that happened in ctsm5.3.067, which won't be on b4b-dev for another two weeks. |
095e8df to
e16d273
Compare
Member
Author
|
Initial |
Change megan_use_gamma_sm to default false The soil moisture effect was added in ctsm5.2.020 with MEGAN2.1 and was hardcoded on. As of ctsm5.3.068 megan_use_gamma_sm became default false, which is closer to MEGAN before 2.1. Hence we made megan_use_gamma_sm default off for all CLM physics versions.
Member
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Adds SUBSETDATAPOINT and SUBSETDATAREGION tests to
aux_clm(and newsubset_datasuite). These runsubset_datafor either a point or a six-cell region, then run CTSM with the outputs.Specific notes
Contributors other than yourself, if any: None
CTSM Issues Fixed:
Are answers expected to change (and if so in what way)? No
Any User Interface Changes (namelist or namelist defaults changes)? No
Does this create a need to change or add documentation? Did you do so? No
Testing performed, if any:
On 0e14784:
aux_clmtesting on Derecho;SUBSETDATAtests fail when trying to generate baseline.aux_clmtesting on IzumiFinal testing:
aux_clmtesting on Derecho (/glade/derecho/scratch/samrabin/tests_0811-170941de)aux_clmtesting on Izumi (/scratch/cluster/samrabin/tests_0811-170954iz/)