Skip to content

Complete CCPPization of CAM5 UW (diag_TKE) PBL scheme; cleanup to vertical_diffusion_tend#1445

Open
jimmielin wants to merge 18 commits intoESCOMP:cam_developmentfrom
jimmielin:hplin/diag_tke
Open

Complete CCPPization of CAM5 UW (diag_TKE) PBL scheme; cleanup to vertical_diffusion_tend#1445
jimmielin wants to merge 18 commits intoESCOMP:cam_developmentfrom
jimmielin:hplin/diag_tke

Conversation

@jimmielin
Copy link
Copy Markdown
Member

@jimmielin jimmielin commented Dec 3, 2025

Companion PR: ESCOMP/atmospheric_physics#370

Purpose of changes (include the issue number and title text for each relevant GitHub issue):

Describe any changes made to build system: added bretherton_park folder to atmos_phys

Describe any changes made to the namelist: update to descriptions only.

List any changes to the defaults for the boundary datasets: N/A

Describe any substantial timing or memory changes: None

Code reviewed by:

List all files eliminated:

D       src/physics/cam/eddy_diff.F90
  - moved to atmos_phys

D       src/physics/cam/pbl_utils.F90
  - only remaining subroutine now in atmos_phys bretherton_park_diff.F90

List all files added and what they do:

List all existing files that have been modified, and describe the changes:

M       bld/configure
  - add bretherton_park subdir for atmos_phys

M       bld/namelist_files/namelist_definition.xml
  - fix description

M       src/control/cam_snapshot_common.F90
  - populate units for pbuf_ksrftms, pbuf_WSEDL

M       src/physics/cam/eddy_diff_cam.F90
  - moved most of existing logic in eddy_diff_tend to new CCPP scheme bretherton_park_diff_run
  - what remains is just CAM-specific code for history and code to interface with the underlying run phase.

M       src/physics/cam/vertical_diffusion.F90
  - move kinematic fluxes and obklen calculation to common interstitial scheme.
  - move input preparation (vert coord for vdiff, potential temp) to common interstitial scheme.
  - rearrange data flow for HB, UW to share as much code as possible.

@cacraigucar cacraigucar marked this pull request as draft February 10, 2026 16:23
@jimmielin jimmielin changed the title Phase 1 of UW PBL CCPPization, cleanup to vertical_diffusion_tend Complete CCPPization of CAM5 UW (diag_TKE) PBL scheme; cleanup to vertical_diffusion_tend Mar 9, 2026
Copy link
Copy Markdown
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the necessary CAM updates @jimmielin! I have some comment update requests/questions, but hopefully nothing too difficult.

Comment thread src/physics/cam/eddy_diff_cam.F90 Outdated
Comment thread src/physics/cam/eddy_diff_cam.F90 Outdated
Comment thread src/physics/cam/eddy_diff_cam.F90 Outdated
Comment thread src/physics/cam/vertical_diffusion.F90 Outdated
@jimmielin jimmielin requested a review from nusbaume April 24, 2026 18:36
Copy link
Copy Markdown
Collaborator

@nusbaume nusbaume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @jimmielin! Everything looks good to me now.

@nusbaume nusbaume requested review from peverwhee and removed request for peverwhee April 27, 2026 15:19
Copy link
Copy Markdown
Collaborator

@cacraigucar cacraigucar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to update atmospheric_physics external

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: No status

Development

Successfully merging this pull request may close these issues.

3 participants