cam6_4_137: Incorporate final RRTMGP mods to complete CPU-ized ccppization #1424
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
peverwhee
commented
Oct 23, 2025
peverwhee
commented
- Bring in latest atmospheric physics tag (To be made) that includes interface updates.
- Add missing snapshot field
- Modify & add new constituent stubs to allow (unused) rrtmgp schemes to build
nusbaume
reviewed
Dec 11, 2025
Collaborator
nusbaume
left a comment
nusbaume
left a comment
There was a problem hiding this comment.
This PR looks good to me @peverwhee!
However, if we can get rid of the references to machine in RRTMGP in your current RRMTGP atmospheric_physics PR, then can we also get rid of the machine.F90 file in src/utils/cam_ccpp as well in this PR? Of course if not then that's fine too, I Just figured it couldn't hurt to check. Thanks!
Collaborator
Author
|
@nusbaume file removed 🎅 |
nusbaume
approved these changes
Dec 17, 2025
Collaborator
nusbaume
left a comment
nusbaume
left a comment
There was a problem hiding this comment.
Thanks for getting rid of the file! Everything looks great to me now.
peverwhee
changed the title
cacraigucar
added a commit
to cacraigucar/CAM
that referenced
this pull request
Dec 22, 2025
Merge pull request ESCOMP#1424 from peverwhee/rrtmgp-final
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.