Eosu 404 auth token reauth p2p disconnects v2#1260
Open
JessTello wants to merge 1 commit intorelease-6.1.0from
Open
Eosu 404 auth token reauth p2p disconnects v2#1260JessTello wants to merge 1 commit intorelease-6.1.0from
JessTello wants to merge 1 commit intorelease-6.1.0from
Conversation
Contributor
JessTello
commented
Mar 19, 2026
JessTello
commented
- Add a single flight guard s_isConnectAuthExpirationLoginInProgress to the Connect re-login flow to avoid duplicate automatic relogins.
- Gate the AuthExpiration callback in ConfigureConnectExpirationCallback so subsequent notifications return early while a reconnect is in progress.
- Clear the in progress guard when Connect.Login completes and when CreateUser completes so legitimate future retries are allowed.
- Add a single flight guard s_isConnectAuthExpirationLoginInProgress to the Connect re-login flow to avoid duplicate automatic relogins. - Gate the AuthExpiration callback in ConfigureConnectExpirationCallback so subsequent notifications return early while a reconnect is in progress. - Clear the in progress guard when Connect.Login completes and when CreateUser completes so legitimate future retries are allowed.
matt-clarke
reviewed
Mar 20, 2026
| // | ||
| public void StartConnectLoginWithOptions(Epic.OnlineServices.Connect.LoginOptions connectLoginOptions, | ||
| OnConnectLoginCallback onloginCallback) | ||
| { |
Contributor
There was a problem hiding this comment.
There's a very rare edge case where a developer could call this function whilst s_isConnectAuthExpirationLoginInProgress is true and a login attempt is ongoing.
To protect against this I would:
- Move this code into a private function
- Either prefixed with
_or ending inInternal(perhaps there are other cases in the plugin already?) - Add an extra bool param, which is used to indicate whether this is the re-auth attempt
- If it's not the re-auth attempt and
s_isConnectAuthExpirationLoginInProgressis true then call the callbacks with theAlreadyPendingresult (and log a warning explaining what happened)
- Either prefixed with
- Keep this public function and have it call that private function (with false for the new param)
matt-clarke
requested changes
Mar 20, 2026
| connectInterface.Login(ref connectLoginOptions, null, | ||
| (ref Epic.OnlineServices.Connect.LoginCallbackInfo connectLoginData) => | ||
| { | ||
| s_isConnectAuthExpirationLoginInProgress = false; |
Contributor
There was a problem hiding this comment.
Can you add this check? There's a convenient extension function for it in the Epic.OnlineServices namespace.
I've also created a thread to discuss this function in general, as I can't see it used elsewhere.
Suggested change
| s_isConnectAuthExpirationLoginInProgress = false; | |
| if (!connectLoginData.ResultCode.IsOperationComplete()) | |
| { | |
| Log($"Ignoring connect login result that will be retried. ResultCode: {connectLoginData.ResultCode}"); | |
| return; | |
| } | |
| s_isConnectAuthExpirationLoginInProgress = false; |
| //------------------------------------------------------------------------- | ||
| public void CreateConnectUserWithContinuanceToken(ContinuanceToken token, | ||
| OnCreateConnectUserCallback onCreateUserCallback) | ||
| { |
Contributor
There was a problem hiding this comment.
This is a public function, so as per the comment below there's an edge case where this could be called whilst s_isConnectAuthExpirationLoginInProgress is true. This also means that it also needs to check the bool and early exit
| SetLocalProductUserId(createUserCallbackInfo.LocalUserId); | ||
| } | ||
|
|
||
| s_isConnectAuthExpirationLoginInProgress = false; |
Contributor
There was a problem hiding this comment.
Could this ever be true here? If we're re-authing then we should never be creating a user
| ref addNotifyAuthExpirationOptions, null, (ref AuthExpirationCallbackInfo callbackInfo) => | ||
| { | ||
| if (s_isConnectAuthExpirationLoginInProgress) | ||
| { |
Contributor
There was a problem hiding this comment.
Can you add logging here to say that it's being ignored. It could be useful to debug an issue
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.