Conversation
…wing to relocate the NSS config file
Collaborator
Author
|
It would be also correct to change "NSS" into "NSS/PAM" in the repo description. I don't have the rights to update it. |
omllobet
approved these changes
May 29, 2026
Member
omllobet
left a comment
omllobet
left a comment
There was a problem hiding this comment.
LGTM Just some little formatting
| struct group *g = getgrnam(*argv+11); | ||
| if(g == NULL){ | ||
| D1("unknown supplementary group: %s", *argv+11); | ||
| continue; |
Comment on lines
+66
to
+67
| D1("unknown supplementary group: %s", *argv+9); | ||
| //continue; |
Collaborator
Author
|
Ready to merge then, or waiting for Sabela's review too ? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We replace the code defining functions with local context passed as argument (ie functional programming), to explicit callbacks.
GCC needed to create crazy stack jumps, which didn't feel that clean.
Not sure other compilers even allow it.
=> we use callbacks.
In this PR, we also include relocating the NSS config file.
call
make NSS_CFGFILE="/etc/other/location/blabla.conf"Finally, we add a PAM setting to swap the main group of a given user.