Skip to content

Test lammps hook #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
laraPPr wants to merge 6 commits into
base: main
Choose a base branch
from
Open

Test lammps hook #186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
78d6a88
Add LAMMPS hook to ignore failing ctest on ARM generic
laraPPr Mar 24, 2026
6041094
add easystack for testing
laraPPr Mar 24, 2026
1f7dce2
fix indentation
laraPPr Mar 24, 2026
b3bc87f
Merge branch 'lammps_hook' into test_lammps_hook
laraPPr Mar 24, 2026
db5b854
fix hook
laraPPr Mar 24, 2026
0fc7eb8
Merge branch 'lammps_hook' into test_lammps_hook
laraPPr Mar 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions easystacks/software.eessi.io/2025.06/eessi-2025.06-eb-5.2.1-2024a.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
easyconfigs:
- kim-api-2.4.1-GCC-13.3.0.eb:
options:
# See https://github.com/easybuilders/easybuild-easyconfigs/pull/25133
from-commit: c484c12aaad5da0e27cd9269d59b4ecaa89927ab
- LAMMPS-22Jul2025-foss-2024a-kokkos.eb:
options:
# See https://github.com/easybuilders/easybuild-easyconfigs/pull/25133
# and https://github.com/easybuilders/easybuild-easyconfigs/pull/25593
from-commit: e2dedae93022d7e3f10bf2983ca8a03b03b0dca0
15 changes: 15 additions & 0 deletions eb_hooks.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1575,6 +1575,20 @@ def pre_test_hook_ignore_failing_tests_OpenBabel_a64fx(self, *args, **kwargs):
self.cfg['testopts'] = "|| echo ignoring failing tests"


def pre_test_hook_ignore_failing_tests_LAMMPS_ARM_generic(self, *args, **kwargs):
"""
Pre-test hook for LAMMPS: skip failing ctest for selected LAMMPS version on ARM generic.

See: https://github.com/lammps/lammps/issues/4926
"""
if self.name == 'LAMMPS' and self.version in ('22Jul2025',):
if os.getenv('EESSI_CPU_FAMILY') == 'aarch64':
mcpu_generic = '-DKokkos_ARCH_ARMV80=yes'
Copy link
Contributor

@boegel boegel Mar 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@laraPPr You can make this more direct by inspecting the value of $EESSI_SOFTWARE_SUBDIR, and comparing it with the existing CPU_TARGET_AARCH64_GENERIC constant?

cpu_target = get_eessi_envvar('EESSI_SOFTWARE_SUBDIR')

see also parse_hook_openblas_relax_lapack_tests_num_errors (but that's for aarch64/neoverse_v1)

cflags = os.getenv('CFLAGS')
if mcpu_generic in cflags:
self.cfg['testopts'] = "|| echo ignoring failing tests"


def pre_single_extension_hook(ext, *args, **kwargs):
"""Main pre-extension: trigger custom functions based on software name."""
if ext.name in PRE_SINGLE_EXTENSION_HOOKS:
Expand Down Expand Up @@ -1986,6 +2000,7 @@ def post_easyblock_hook(self, *args, **kwargs):
'netCDF': pre_test_hook_ignore_failing_tests_netCDF,
'OpenBabel': pre_test_hook_ignore_failing_tests_OpenBabel_a64fx,
'PyTorch': pre_test_hook_increase_max_failed_tests_arm_PyTorch,
'LAMMPS': pre_test_hook_ignore_failing_tests_LAMMPS_ARM_generic,
}

PRE_SINGLE_EXTENSION_HOOKS = {
Expand Down
Loading