Only disconnect from db pool when size is increasing#467
Merged
adamruzicka merged 3 commits intoDynflow:masterfrom Jan 21, 2026
Merged
Only disconnect from db pool when size is increasing#467adamruzicka merged 3 commits intoDynflow:masterfrom
adamruzicka merged 3 commits intoDynflow:masterfrom
Conversation
Contributor
Author
|
@adamruzicka what do you think? |
adamruzicka
reviewed
Jan 20, 2026
Contributor
adamruzicka
left a comment
There was a problem hiding this comment.
In general I don't have any objections, thank you for polishing something that has been sitting there for almost a decade.
The comments are not hard requirements, but rather "while we're at it"-style comments
Contributor
|
Thank you @jturel ! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first request to hit the server that initializes dynflow is excruciatingly long. It turns out that dynflow disconnects the db pool before maybe increasing the pool size. In katello devel the database.yml pool size matches dynflow's target size which highlights the problem.
Ping illustrates it perfectly:
Before:
After: