Skip to content

Explicitly allocate memory for slices #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
hollowness-inside wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Explicitly allocate memory for slices #25

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1093216
Explicitly allocate memory for slice
hollowness-inside Apr 22, 2024
662a0f3
Explicitly allocate memory for slices
hollowness-inside Apr 23, 2024
28aebb2
Merge branch 'wav-writer-slice-allocation' of https://github.com/holl…
hollowness-inside Apr 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions wave/writer.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,6 @@ func int32ToBytes(i int) []byte {
}

func framesToData(frames []Frame, wfmt WaveFmt) (WaveData, []byte) {
b := []byte{}
raw := samplesToRawData(frames, wfmt)

// We receive frames but have to store the size of the samples
Expand All @@ -88,6 +87,7 @@ func framesToData(frames []Frame, wfmt WaveFmt) (WaveData, []byte) {
subBytes := int32ToBytes(subchunksize)

// construct the data part..
b := make([]byte, 0, 8+len(raw))
b = append(b, Subchunk2ID...)
b = append(b, subBytes...)
b = append(b, raw...)
Expand All @@ -103,7 +103,7 @@ func framesToData(frames []Frame, wfmt WaveFmt) (WaveData, []byte) {

func floatToBytes(f float64, nBytes int) []byte {
bits := math.Float64bits(f)
bs := make([]byte, 8)
bs := make([]byte, 0, 8)
binary.LittleEndian.PutUint64(bs, bits)
// trim padding
switch nBytes {
Expand Down Expand Up @@ -134,8 +134,6 @@ func rescaleFrame(s Frame, bits int) int {
}

func fmtToBytes(wfmt WaveFmt) []byte {
b := []byte{}

subchunksize := int32ToBytes(wfmt.Subchunk1Size)
audioformat := int16ToBytes(wfmt.AudioFormat)
numchans := int16ToBytes(wfmt.NumChannels)
Expand All @@ -144,6 +142,7 @@ func fmtToBytes(wfmt WaveFmt) []byte {
blockalign := int16ToBytes(wfmt.BlockAlign)
bitsPerSample := int16ToBytes(wfmt.BitsPerSample)

b := make([]byte, 0, 23)
b = append(b, wfmt.Subchunk1ID...)
b = append(b, subchunksize...)
b = append(b, audioformat...)
Expand All @@ -159,11 +158,11 @@ func fmtToBytes(wfmt WaveFmt) []byte {
// turn the sample to a valid header
func createHeader(wd WaveData) []byte {
// write chunkID
bits := []byte{}

chunksize := 36 + wd.Subchunk2Size
cb := int32ToBytes(chunksize)

bits := make([]byte, 0, 12)
bits = append(bits, ChunkID...) // in theory switch on endianness..
bits = append(bits, cb...)
bits = append(bits, WaveID...)
Expand Down