Skip to content

Conversation

@thyseus
Copy link

@thyseus thyseus commented Jan 16, 2026

the default behavior of enabling the plugin everywhere is dangerous, one may accidentally push the code to production.

the default behavior of enabling the plugin everywhere
is dangerous, one may accidentally push the code to
production.
@thyseus
Copy link
Author

thyseus commented Jan 16, 2026

alternatively i thought about = false so the buttons would simply "disappear" instead of throwing an exception on existing installations ?

@bramr94
Copy link
Collaborator

bramr94 commented Jan 16, 2026

That sounds like a good solution @thyseus

@thyseus
Copy link
Author

thyseus commented Jan 16, 2026

So should i add the = false ? Downside is: having enabled() and then nothing happens, because, in fact, its disabled, is confusing. Both solutions have their downsides :)

@thyseus
Copy link
Author

thyseus commented Jan 18, 2026

Last idea: we can rename it to enabledWhen() and make the parameter required, then its obvious what the method does ?

Would be an even bigger breaking change then, though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants