Skip to content

feat: fe update for evaluations in client side #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
seangaaab merged 2 commits into from
Oct 13, 2025
Merged

feat: fe update for evaluations in client side #97

seangaaab merged 2 commits into from
Oct 13, 2025

Conversation

@ejminguez
Copy link

@ejminguez ejminguez commented Oct 12, 2025 •
edited
Loading

Changes

  • PyCon evaluation route renders independently.
  • EventDetails replaced with PyCon’s variant.
  • Questions match Google Doc (text, options, requiredness, order).
  • Validation blocks progression/submit when invalid.
  • Submission payload correct and API call succeeds.
  • UI matches PyCon branding.
  • No regressions in general evaluation flow.

@ejminguez ejminguez self-assigned this Oct 12, 2025
@ejminguez ejminguez requested a review from seangaaab October 12, 2025 16:47
seangaaab
seangaaab approved these changes Oct 13, 2025
View reviewed changes
Copy link

@seangaaab seangaaab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seangaaab seangaaab merged commit e2e21e8 into stage Oct 13, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@seangaaab seangaaab seangaaab approved these changes

Assignees

@ejminguez ejminguez

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ejminguez @seangaaab