Skip to content

Fix noise settings#9

Open
aguinot wants to merge 1 commit intomainfrom
fix_ci
Open

Fix noise settings#9
aguinot wants to merge 1 commit intomainfrom
fix_ci

Conversation

@aguinot
Copy link
Copy Markdown
Collaborator

@aguinot aguinot commented Feb 28, 2026

Fix the noise settings to match what was used to generate the current ref image. This should fix the CI test

Fix the noise settings to match what was used to generate the current ref image. This should fix the CI test
@sidneymau
Copy link
Copy Markdown
Contributor

I just tested locally and get a discrepancy --

>       np.testing.assert_allclose(output_data, reference_data, rtol=RTOL, atol=ATOL)
E       AssertionError: 
E       Not equal to tolerance rtol=0, atol=0.1
E       
E       Mismatched elements: 74 / 16711744 (0.000443%)
E       Max absolute difference among violations: 13.
E       Max relative difference among violations: 0.12149533
E        ACTUAL: array([[65., 48., 72., ..., 59., 70., 64.],
E              [70., 58., 51., ..., 51., 57., 60.],
E              [71., 64., 65., ..., 46., 76., 38.],...
E        DESIRED: array([[65., 48., 72., ..., 59., 70., 64.],
E              [70., 58., 51., ..., 51., 57., 60.],
E              [71., 64., 65., ..., 46., 76., 38.],...

tests/test_end_to_end.py:71: AssertionError

it's pretty close in most cases, but 74 pixels are off

@sidneymau
Copy link
Copy Markdown
Contributor

Do we still want to merge these changes? If so, I think we need to update the branch and then run the Make Reference Image workflow

@aguinot
Copy link
Copy Markdown
Collaborator Author

aguinot commented Mar 19, 2026

Now the main branch run but the created image does not contain noise. I guess it is up to us to decide if we want the noise to be included in the reference image. But as you said this will not fix anymore and will require to re-generate the ref image.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants