Skip to content

fix: handle rich text field potentially being an empty list #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
G-Rath merged 1 commit into from
Jun 2, 2025
Merged

fix: handle rich text field potentially being an empty list #60

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions scripts/generate_osv_advisories.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -295,11 +295,13 @@ def build_affected_ranges(sa_advisory: drupal.Advisory) -> list[osv.Range]:
]


def get_credits_from_sa(credits: drupal.RichTextField) -> list[osv.Credit]:
def get_credits_from_sa(
credits: drupal.RichTextField | list[typing.Never],
) -> list[osv.Credit]:
credit_list: list[osv.Credit] = []

# Sanity checks.
if len(credits) == 0 or 'value' not in credits:
if not isinstance(credits, dict):
return credit_list
# The credits['value'] is a sting with an ordered list of credits.
# A credit is a link to the user's profile on drupal.org with the user's name as the link text.
Expand Down
2 changes: 1 addition & 1 deletion scripts/typings/drupal.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ class Advisory(Node):
field_affected_versions: str | None
field_project: EntityReferenceField
field_fixed_in: list[EntityReferenceField]
field_sa_reported_by: RichTextField
field_sa_reported_by: RichTextField | list[typing.Never]
field_sa_criticality: str
field_sa_cve: list[str]
field_sa_description: RichTextField
Expand Down