Skip to content

fix: ensure drupal/currency advisories use Drupal repository in their ecosystem#192

Merged
G-Rath merged 1 commit intomainfrom
special-case-currency
Mar 19, 2026
Merged

fix: ensure drupal/currency advisories use Drupal repository in their ecosystem#192
G-Rath merged 1 commit intomainfrom
special-case-currency

Conversation

@G-Rath
Copy link
Copy Markdown
Collaborator

@G-Rath G-Rath commented Mar 18, 2026

It seems there are a handful of Drupal packages exist in both Packagist and in the Drupal repository:

drupal/acquia_cms_dam exists in both repos and has packages
drupal/arch exists in both repos and has packages
drupal/computed_relationships exists in both repos and has packages
drupal/cors exists in both repos and has packages
drupal/currency exists in both repos and has packages
drupal/default_content exists in both repos and has packages
drupal/devel exists in both repos and has packages
drupal/dynamic_entity_reference exists in both repos and has packages
drupal/ems exists in both repos and has packages
drupal/external_entity exists in both repos and has packages
drupal/fillpdf exists in both repos and has packages
drupal/openstack_queues exists in both repos and has packages
drupal/operations exists in both repos and has packages
drupal/payment exists in both repos and has packages
drupal/root exists in both repos and has packages
drupal/stringoverrides exists in both repos and has packages

This means advisories for those packages will currently have the wrong ecosystem (sort of), though in practice it looks like drupal/currency is the only package with an actual advisory so I've added that as a special case rather than do anything more complex

@G-Rath G-Rath requested review from Unifex, greggles and longwave March 18, 2026 19:09
@G-Rath
Copy link
Copy Markdown
Collaborator Author

G-Rath commented Mar 18, 2026

This was caught by #161

Copy link
Copy Markdown
Collaborator

@Unifex Unifex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While I'm not comfortable with having an exception like this, I'm not seeing a good way of resolving this without having the package removed from one of those locations.

This feels acceptable for now.

@G-Rath G-Rath merged commit 503006c into main Mar 19, 2026
9 checks passed
@G-Rath G-Rath deleted the special-case-currency branch March 19, 2026 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants