fix: ensure drupal/currency advisories use Drupal repository in their ecosystem#192
Merged
fix: ensure drupal/currency advisories use Drupal repository in their ecosystem#192
drupal/currency advisories use Drupal repository in their ecosystem#192Conversation
Collaborator
Author
|
This was caught by #161 |
Unifex
approved these changes
Mar 18, 2026
Collaborator
Unifex
left a comment
There was a problem hiding this comment.
While I'm not comfortable with having an exception like this, I'm not seeing a good way of resolving this without having the package removed from one of those locations.
This feels acceptable for now.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems there are a handful of Drupal packages exist in both Packagist and in the Drupal repository:
This means advisories for those packages will currently have the wrong ecosystem (sort of), though in practice it looks like
drupal/currencyis the only package with an actual advisory so I've added that as a special case rather than do anything more complex