Skip to content

Conversation

@beniaminopozzan
Copy link
Collaborator

No description provided.

@beniaminopozzan beniaminopozzan self-assigned this Oct 20, 2025
@beniaminopozzan beniaminopozzan marked this pull request as draft October 20, 2025 21:50
@mrpollo
Copy link
Contributor

mrpollo commented Oct 20, 2025

if this works you are my hero!

Signed-off-by: Beniamino Pozzan <beniamino.pozzan@gmail.com>
Signed-off-by: Beniamino Pozzan <beniamino.pozzan@gmail.com>
@beniaminopozzan beniaminopozzan marked this pull request as ready for review October 20, 2025 23:25
Signed-off-by: Beniamino Pozzan <beniamino.pozzan@gmail.com>
@beniaminopozzan
Copy link
Collaborator Author

@mrpollo

  • first build -> no cache (makes sense as scope changed)
  • second build where only one file was added -> cache was used! action time dropped to 5 min
  • third build with rebase and the file was removed -> cache was used! action time agan 5 min

however, this other pr: #32 which is made on top of this one did not used the cache at all https://github.com/Dronecode/roscon-25-workshop/actions/runs/18667702426 (I cancelled the workflow when I saw no cache being used)

could you still approve please? Once the change is in main it might behave properly even for other PRs, thanks!

(if merging, please quash and merge 🙇🏻 )

@mrpollo mrpollo merged commit cfd6082 into main Oct 21, 2025
3 checks passed
@mrpollo
Copy link
Contributor

mrpollo commented Oct 21, 2025

hero status confirmed

@mrpollo
Copy link
Contributor

mrpollo commented Oct 21, 2025

i didnt read the squash part sorry lol

@beniaminopozzan
Copy link
Collaborator Author

@mrpollo I'm not 100% convinced it worked as intended:
https://github.com/Dronecode/roscon-25-workshop/actions/runs/18668707616
the post merge action did not use any cache at all

@beniaminopozzan
Copy link
Collaborator Author

tested with a few other PRs and the cache is not invalidated anymore :)

interestingly, when merging the RPs into main I would have expected to cache all layers from the previous built.
For example, for the PR #32, the last action to run on the pr sync event is https://github.com/Dronecode/roscon-25-workshop/actions/runs/18679620637. That action built the image and pushed the cache.
The RP was then closed and the branch merged, which triggered https://github.com/Dronecode/roscon-25-workshop/actions/runs/18680298157. This action used some cache for both arm64 and amd64 which is good, but it did not used the cache for ALL layers. I would have expected it to retrieve from the cache all layers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants