-
Notifications
You must be signed in to change notification settings - Fork 12
ci: set cache scope #30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
if this works you are my hero! |
Signed-off-by: Beniamino Pozzan <beniamino.pozzan@gmail.com>
Signed-off-by: Beniamino Pozzan <beniamino.pozzan@gmail.com>
2aada4e to
e515b61
Compare
Signed-off-by: Beniamino Pozzan <beniamino.pozzan@gmail.com>
however, this other pr: #32 which is made on top of this one did not used the cache at all https://github.com/Dronecode/roscon-25-workshop/actions/runs/18667702426 (I cancelled the workflow when I saw no cache being used) could you still approve please? Once the change is in (if merging, please quash and merge 🙇🏻 ) |
|
hero status confirmed |
|
i didnt read the squash part sorry lol |
|
@mrpollo I'm not 100% convinced it worked as intended: |
|
tested with a few other PRs and the cache is not invalidated anymore :) interestingly, when merging the RPs into main I would have expected to cache all layers from the previous built. |
No description provided.