Update dependency rmccue/requests to v1.8.0 [SECURITY] - abandoned#6
Open
renovate[bot] wants to merge 1 commit intomasterfrom
Open
Update dependency rmccue/requests to v1.8.0 [SECURITY] - abandoned#6renovate[bot] wants to merge 1 commit intomasterfrom
renovate[bot] wants to merge 1 commit intomasterfrom
Conversation
Author
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. |
Author
Autoclosing SkippedThis PR has been flagged for autoclosing. However, it is being skipped due to the branch being already modified. Please close/delete it manually or report a bug if you think this is in error. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR contains the following updates:
1.6.1->1.8.0⚠ Dependency Lookup Warnings ⚠
Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information.
GitHub Vulnerability Alerts
CVE-2021-29476
Impact
Unserialization of untrusted data.
Patches
The issue has been patched and users of
Requests1.6.0, 1.6.1 and 1.7.0 should update to version 1.8.0.References
Publications about the vulnerability:
Originally fixed in WordPress 5.5.2:
Related Security Advisories:
Notification to the Requests repo including a fix in:
For more information
If you have any questions or comments about this advisory:
Release Notes
WordPress/Requests
v1.8.0Compare Source
IMPORTANT NOTES
Last release supporting PHP 5.2 - 5.5
Release 1.8.0 will be the last release with compatibility for PHP 5.2 - 5.5. With the next release (v2.0.0), the minimum PHP version will be bumped to 5.6.
Last release supporting PEAR distribution
Release 1.8.0 will be the last release to be distributed via PEAR. From release 2.0.0 onwards, consumers of this library will have to switch to Composer to receive updates.
Overview of changes
[SECURITY FIX] Disable deserialization in
FilteredIteratorA
Deserialization of Untrusted Dataweakness was found in theFilteredIteratorclass.This security vulnerability was first reported to the WordPress project. The security fix applied to WordPress has been ported back into the library.
GitHub security advisory: Insecure Deserialization of untrusted data
CVE: CVE-2021-29476 - Deserialization of Untrusted Data
Related WordPress CVE: https://cve.mitre.org/cgi-bin/cvename.cgi?name=2020-28032
(props [@dd32][gh-dd32], [@desrosj][gh-desrosj], [@jrfnl][gh-jrfnl], [@peterwilsoncc][gh-peterwilsoncc], [@SergeyBiryukov][gh-SergeyBiryukov], [@whyisjake][gh-whyisjake], [@xknown][gh-xknown], #421, #422)
Repository moved to
WordPress\RequestsThe
Requestslibrary has been moved to the WordPress GitHub organization and can now be found underhttps://github.com/WordPress/Requests.All links in code and documentation were updated accordingly.
Note: the Composer package name remains unchanged (
rmccue/requests), as well as the documentation site (requests.ryanmccue.info).(props [@dd32][gh-dd32], [@JustinyAhin][gh-JustinyAhin], [@jrfnl][gh-jrfnl], [@rmccue][gh-rmccue], #440, #441, #448)
Manage
"Expect"header withcURLtransportBy default,
cURLadds aExpect: 100-Continueheader to certain requests. This can add as much as a second delay to requests done usingcURL. This is discussed on the cURL mailing list.To prevent this,
Requestsnow adds an empty"Expect"header to requests that are smaller than 1 MB and use HTTP/1.1.(props [@carlalexander][gh-carlalexander], [@schlessera][gh-schlessera], [@TimothyBJacobs][gh-TimothyBJacobs], #453, #454, #469)
Update bundled certificates as of 2021-02-12
The bundled certificates were updated. A small subset of expired certificates are still included for legacy reasons (and support).
(props [@ozh][gh-ozh], [@patmead][gh-patmead], [@schlessera][gh-schlessera], [@todeveni][gh-todeveni], #385, #398, #451)
Add required
Content-*headers for emptyPOSTrequestsSends the
Content-LengthandContent-Typeheaders even for emptyPOSTrequests, as the length is expected as per RFC2616 Section 14.13:(props [@dd32][gh-dd32], [@gstrauss][gh-gstrauss], [@jrfnl][gh-jrfnl], [@soulseekah][gh-soulseekah], #248, #249, #318, #368)
Ignore locale when creating the HTTP version string from a float
The previous behavior allowed for the locale to mess up the float to string conversion resulting in a
GET / HTTP/1,1instead ofGET / HTTP/1.1request.(props [@tonebender][gh-tonebender], [@Zegnat][gh-Zegnat], #335, #339)
Make
verify => falsework withfsockopenThis allows the
fsockopentransport now to ignore SSL failures when requested.(props [@soulseekah][gh-soulseekah], #310, #311)
Only include port number in the
Hostheader if it differs from the defaultThe code was not violating the RFC per se, but also not following standard practice of leaving the port off when it is the default port for the scheme, which could lead to connectivity issues.
(props [@amandato][gh-amandato], [@dd32][gh-dd32], #238)
Fix PHP cross-version compatibility
Important fixes have been made to improve cross-version compatibility of the code across all supported PHP versions.
implode()arguments.$urlproperty tostringinRequests::parse_response().$bodyproperty to an empty string inRequests::parse_response().$callbackin theFilteredIteratoris callable before calling it.(props [@aaronjorbin][gh-aaronjorbin], [@jrfnl][gh-jrfnl], #346, #370, #425, #426, #456, #457)
Improve testing
Lots of improvements were made to render the tests more reliable and increase the coverage.
And to top it all off, all tests are now run against all supported PHP versions, including PHP 8.0.
(props [@datagutten][gh-datagutten], [@jrfnl][gh-jrfnl], [@schlessera][gh-schlessera], #345, #351, #355, #366, #412, #414, #445, #458, #464)
Improve code quality and style
A whole swoop of changes has been made to harden the code and make it more consistent.
The code style has been made consistent across both code and tests and is now enforced via a custom PHPCS rule set.
The WordPress Coding Standards were chosen as the basis for the code style checks as most contributors to this library originate from the WordPress community and will be familiar with this code style.
Main differences from the WordPress Coding Standards based on discussions and an analysis of the code styles already in use:
A more detailed overview of the decisions that went into the final code style rules can be found at #434.
(props [@jrfnl][gh-jrfnl], [@KasperFranz][gh-KasperFranz], [@ozh][gh-ozh], [@schlessera][gh-schlessera], [@TysonAndre][gh-TysonAndre], #263, #296, #328, #358, #359, #360, #361, #362, #363, #364, #386, #396, #399, #400, #401, #402, #403, #404, #405, #406, #408, #409, #410, #411, #413, #415, #416, #417, #423, #424, #434)
Replace Travis CI with GitHub Actions (partial)
The entire CI setup is gradually being moved from Travis CI to GitHub Actions.
At this point, GitHub Actions takes over the CI from PHP 5.5 onwards, leaving Travis CI as a fallback for lower PHP versions.
This move will be completed after the planned minimum version bump to PHP 5.6+ with the next release, at which point we will get rid of all the remaining Travis CI integrations.
(props [@dd32][gh-dd32], [@desrosj][gh-desrosj], [@jrfnl][gh-jrfnl], [@ntwb][gh-ntwb], [@ozh][gh-ozh], [@schlessera][gh-schlessera], [@TimothyBJacobs][gh-TimothyBJacobs], [@TysonAndre][gh-TysonAndre], #280, #298, #302, #303, #352, #353, #354, #356, #388, #397, #428, #436, #439, #461, #467)
Update and improve documentation
README.mdfile.(props [@desrosj][gh-desrosj], [@jrfnl][gh-jrfnl], [@JustinyAhin][gh-JustinyAhin], [@tnorthcutt][gh-tnorthcutt], #334, #367, #387, #443, #462, #465, #468, #471 )
v1.7.0Compare Source
Add support for HHVM and PHP 7
Requests is now tested against both HHVM and PHP 7, and they are supported as
first-party platforms.
(props [@rmccue][gh-rmccue], #106, #176)
Transfer & connect timeouts, in seconds & milliseconds
cURL is unable to handle timeouts under a second in DNS lookups, so we round
those up to ensure 1-999ms isn't counted as an instant failure.
(props [@ozh][gh-ozh], [@rmccue][gh-rmccue], #97, #216)
Rework cookie handling to be more thorough.
Cookies are now restricted to the same-origin by default, expiration is checked.
(props [@catharsisjelly][gh-catharsisjelly], [@rmccue][gh-rmccue], #120, #124, #130, #132, #156)
Improve testing
Tests are now run locally to speed them up, as well as further general
improvements to the quality of the testing suite. There are now also
comprehensive proxy tests to ensure coverage there.
(props [@rmccue][gh-rmccue], #75, #107, #170, #177, #181, #183, #185, #196, #202, #203)
Support custom HTTP methods
Previously, custom HTTP methods were only supported on sockets; they are now
supported across all transports.
(props [@ocean90][gh-ocean90], #227)
Add byte limit option
(props [@rmccue][gh-rmccue], #172)
Support a Requests_Proxy_HTTP() instance for the proxy setting.
(props [@ocean90][gh-ocean90], #223)
Add progress hook
(props [@rmccue][gh-rmccue], #180)
Add a before_redirect hook to alter redirects
(props [@rmccue][gh-rmccue], #205)
Pass cURL info to after_request
(props [@rmccue][gh-rmccue], #206)
Remove explicit autoload in Composer installation instructions
(props [@SlikNL][gh-SlikNL], #86)
Restrict CURLOPT_PROTOCOLS on
defined()instead ofversion_compare()(props [@ozh][gh-ozh], #92)
Fix doc - typo in "Authentication"
(props [@remik][gh-remik], #99)
Contextually check for a valid transport
(props [@ozh][gh-ozh], #101)
Follow relative redirects correctly
(props [@ozh][gh-ozh], #103)
Use cURL's version_number
(props [@mishan][gh-mishan], #104)
Removed duplicated option docs
(props [@staabm][gh-staabm], #112)
code styling fixed
(props [@imsaintx][gh-imsaintx], #113)
Fix IRI "normalization"
(props [@ozh][gh-ozh], #128)
Mention two PHP extension dependencies in the README.
(props [@orlitzky][gh-orlitzky], #136)
Ignore coverage report files
(props [@ozh][gh-ozh], #148)
drop obsolete "return" after throw
(props [@staabm][gh-staabm], #150)
Updated exception message to specify both http + https
(props [@beutnagel][gh-beutnagel], #162)
Sets
stream_headersmethod to public to allow calling it from otherplaces.
(props [@adri][gh-adri], #158)
Remove duplicated stream_get_meta_data call
(props [@rmccue][gh-rmccue], #179)
Transmits $errno from stream_socket_client in exception
(props [@laurentmartelli][gh-laurentmartelli], #174)
Correct methods to use snake_case
(props [@rmccue][gh-rmccue], #184)
Improve code quality
(props [@rmccue][gh-rmccue], #186)
Update Build Status image
(props [@rmccue][gh-rmccue], #187)
Fix/Rationalize transports (v2)
(props [@rmccue][gh-rmccue], #188)
Surface cURL errors
(props [@ifwe][gh-ifwe], #194)
Fix for memleak and curl_close() never being called
(props [@kwuerl][gh-kwuerl], #200)
addex how to install with composer
(props [@royopa][gh-royopa], #164)
Uppercase the method to ensure compatibility
(props [@rmccue][gh-rmccue], #207)
Store default certificate path
(props [@rmccue][gh-rmccue], #210)
Force closing keep-alive connections on old cURL
(props [@rmccue][gh-rmccue], #211)
Docs: Updated HTTP links with HTTPS links where applicable
(props [@ntwb][gh-ntwb], #215)
Remove the executable bit
(props [@ocean90][gh-ocean90], #224)
Change more links to HTTPS
(props [@rmccue][gh-rmccue], #217)
Bail from cURL when either
curl_init()ORcurl_exec()are unavailable(props [@dd32][gh-dd32], #230)
Disable OpenSSL's internal peer_name checking when
verifynameis disabled.(props [@dd32][gh-dd32], #239)
Only include the port number in the
Hostheader when it differs fromdefault
(props [@dd32][gh-dd32], #238)
Respect port if specified for HTTPS connections
(props [@dd32][gh-dd32], #237)
Allow paths starting with a double-slash
(props [@rmccue][gh-rmccue], #240)
Fixes bug in rfc2616 #3.6.1 implementation.
(props [@stephenharris][gh-stephenharris], #236, #3)
CURLOPT_HTTPHEADER在php7接受空数组导致php-fpm奔溃
(props [@qibinghua][gh-qibinghua], #219)
Configuration
📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.