Huey schdule fixes and test uniformization #24
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Herklos
approved these changes
Jan 13, 2026
| assert task_result == expected_result | ||
| if encrypted_result: | ||
| assert isinstance(json.loads(result[octobot_node.app.enums.TaskResultKeys.METADATA.value]), dict) | ||
| assert result[octobot_node.app.enums.TaskResultKeys.METADATA.value] |
Comment on lines
+71
to
+80
| next_execution_time = next_actions_description.get_next_execution_time() | ||
| now_time = time.time() | ||
| if next_execution_time == 0 or next_execution_time < now_time: | ||
| delay = 0 | ||
| else: | ||
| next_execution_time = datetime.datetime.fromtimestamp( | ||
| next_actions_description.get_next_execution_time(), | ||
| tz=datetime.timezone.utc | ||
| ) | ||
| execute_octobot.schedule(args=[task], eta=next_execution_time) | ||
| delay = next_execution_time - now_time | ||
| logging.getLogger("octobot_node.scheduler.tasks").info( | ||
| f"Scheduling task '{task.name}' for execution in {delay} seconds" | ||
| ) | ||
| return execute_octobot.schedule(args=[task], delay=delay) |
octobot_node/scheduler/scheduler.py
Outdated
Comment on lines
55
to
58
| elif settings.USE_MEMORY_SCHEDULER: | ||
| # warning: this mode has no persistence, tasks will be lost when the process is stopped | ||
| self.logger.info("Initializing scheduler with memory backend") | ||
| self.INSTANCE = MemoryHuey(DEFAULT_NAME) |
Member
There was a problem hiding this comment.
I think we could use something like an init arg or class global variable to set this value if users shouldn't use it
Member
Author
There was a problem hiding this comment.
It's now disabled, we now use sqlitehuey in tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.