Open
Conversation
split tryMatchingCommand into prefix & name check and signature validation
Author
|
I realized that by switching the order this way, the error-handling block for tryMatchingCommand in findMatchingCommand would cause a response to incorrect command uses regardless of the prefilters. Now, tryMatchingCommand has been split into two parts. The first is used to check the name and prefix before the prefilters, and the second is used to validate the signature and prepare relevant error messages after the prefilters. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As used in https://github.com/Dragory/modmailbot, each command prefilter may check a channel ID against an entire database of threads. As a standalone operation, this has an unnoticeable effect, but when there are over forty commands and nearly one hundred thousand threads, a consistent delay is present on every Modmail command run in the inbox server.
Recently, we pinpointed the source of the delay to this module. Several months ago, the support server advised us to contact Discord for selectively limiting the bot's requests to one particular server.
This change drastically improves the performance (1300ms to <1ms) of findMatchingCommand in large-scale workloads by putting the cheaper and more specific tryMatchingCommand check before the prefilters.