Skip to content

DrDroid AI: Fix: Log GitHub 403 errors as info instead of error #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
doctor-droid-app wants to merge 1 commit into
base: master
Choose a base branch
from
+66 −22
Open

DrDroid AI: Fix: Log GitHub 403 errors as info instead of error #133

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
88 changes: 66 additions & 22 deletions drdroid_debug_toolkit/core/integrations/source_api_processors/github_api_processor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -667,8 +667,12 @@ def list_recent_commits(self, repo, since=None, until=None, per_page=100):
break
page += 1
else:
logger.error(f"GithubAPIProcessor.list_recent_commits:: Error fetching commits for {self.org}/{repo} "
f"with status_code: {response.status_code} and response: {response.text}")
if response.status_code == 403:
logger.info(f"GithubAPIProcessor.list_recent_commits:: No access to commits for {self.org}/{repo} "
f"with status_code: 403 (token lacks permission)")
else:
logger.error(f"GithubAPIProcessor.list_recent_commits:: Error fetching commits for {self.org}/{repo} "
f"with status_code: {response.status_code} and response: {response.text}")
break

return all_commits
Expand Down Expand Up @@ -715,8 +719,12 @@ def list_pull_requests(self, repo, state='all', sort='updated', direction='desc'
break
page += 1
else:
logger.error(f"GithubAPIProcessor.list_pull_requests:: Error fetching PRs for {self.org}/{repo} "
f"with status_code: {response.status_code} and response: {response.text}")
if response.status_code == 403:
logger.info(f"GithubAPIProcessor.list_pull_requests:: No access to PRs for {self.org}/{repo} "
f"with status_code: 403 (token lacks permission)")
else:
logger.error(f"GithubAPIProcessor.list_pull_requests:: Error fetching PRs for {self.org}/{repo} "
f"with status_code: {response.status_code} and response: {response.text}")
break

return all_prs
Expand All @@ -743,8 +751,12 @@ def get_pull_request(self, repo, pr_number):
if response.status_code == 200:
return response.json()
else:
logger.error(f"GithubAPIProcessor.get_pull_request:: Error fetching PR #{pr_number} for {self.org}/{repo} "
f"with status_code: {response.status_code} and response: {response.text}")
if response.status_code == 403:
logger.info(f"GithubAPIProcessor.get_pull_request:: No access to PR #{pr_number} for {self.org}/{repo} "
f"with status_code: 403 (token lacks permission)")
else:
logger.error(f"GithubAPIProcessor.get_pull_request:: Error fetching PR #{pr_number} for {self.org}/{repo} "
f"with status_code: {response.status_code} and response: {response.text}")
return None
except Exception as e:
logger.error(f"GithubAPIProcessor.get_pull_request:: Exception occurred for PR #{pr_number} in {self.org}/{repo}: {e}")
Expand Down Expand Up @@ -780,8 +792,12 @@ def list_releases(self, repo, per_page=100):
break
page += 1
else:
logger.error(f"GithubAPIProcessor.list_releases:: Error fetching releases for {self.org}/{repo} "
f"with status_code: {response.status_code} and response: {response.text}")
if response.status_code == 403:
logger.info(f"GithubAPIProcessor.list_releases:: No access to releases for {self.org}/{repo} "
f"with status_code: 403 (token lacks permission)")
else:
logger.error(f"GithubAPIProcessor.list_releases:: Error fetching releases for {self.org}/{repo} "
f"with status_code: {response.status_code} and response: {response.text}")
break

return all_releases
Expand All @@ -808,8 +824,12 @@ def get_release(self, repo, release_id):
if response.status_code == 200:
return response.json()
else:
logger.error(f"GithubAPIProcessor.get_release:: Error fetching release {release_id} for {self.org}/{repo} "
f"with status_code: {response.status_code} and response: {response.text}")
if response.status_code == 403:
logger.info(f"GithubAPIProcessor.get_release:: No access to release {release_id} for {self.org}/{repo} "
f"with status_code: 403 (token lacks permission)")
else:
logger.error(f"GithubAPIProcessor.get_release:: Error fetching release {release_id} for {self.org}/{repo} "
f"with status_code: {response.status_code} and response: {response.text}")
return None
except Exception as e:
logger.error(f"GithubAPIProcessor.get_release:: Exception occurred for release {release_id} in {self.org}/{repo}: {e}")
Expand All @@ -833,8 +853,12 @@ def get_repository_info(self, repo):
if response.status_code == 200:
return response.json()
else:
logger.error(f"GithubAPIProcessor.get_repository_info:: Error fetching repo info for {self.org}/{repo} "
f"with status_code: {response.status_code} and response: {response.text}")
if response.status_code == 403:
logger.info(f"GithubAPIProcessor.get_repository_info:: No access to repo info for {self.org}/{repo} "
f"with status_code: 403 (token lacks permission)")
else:
logger.error(f"GithubAPIProcessor.get_repository_info:: Error fetching repo info for {self.org}/{repo} "
f"with status_code: {response.status_code} and response: {response.text}")
return None
except Exception as e:
logger.error(f"GithubAPIProcessor.get_repository_info:: Exception occurred for {self.org}/{repo}: {e}")
Expand Down Expand Up @@ -875,8 +899,12 @@ def get_commit_files(self, repo, commit_sha):
})
return files
else:
logger.error(f"GithubAPIProcessor.get_commit_files:: Error fetching commit {commit_sha} for {self.org}/{repo} "
f"with status_code: {response.status_code}")
if response.status_code == 403:
logger.info(f"GithubAPIProcessor.get_commit_files:: No access to commit {commit_sha} for {self.org}/{repo} "
f"with status_code: 403 (token lacks permission)")
else:
logger.error(f"GithubAPIProcessor.get_commit_files:: Error fetching commit {commit_sha} for {self.org}/{repo} "
f"with status_code: {response.status_code}")
return []
except Exception as e:
logger.error(f"GithubAPIProcessor.get_commit_files:: Exception occurred for {self.org}/{repo}: {e}")
Expand Down Expand Up @@ -909,8 +937,12 @@ def get_commit_comments(self, repo, commit_sha):
})
return comments
else:
logger.error(f"GithubAPIProcessor.get_commit_comments:: Error fetching comments for commit {commit_sha} "
f"in {self.org}/{repo} with status_code: {response.status_code}")
if response.status_code == 403:
logger.info(f"GithubAPIProcessor.get_commit_comments:: No access to comments for commit {commit_sha} "
f"in {self.org}/{repo} with status_code: 403 (token lacks permission)")
else:
logger.error(f"GithubAPIProcessor.get_commit_comments:: Error fetching comments for commit {commit_sha} "
f"in {self.org}/{repo} with status_code: {response.status_code}")
return []
except Exception as e:
logger.error(f"GithubAPIProcessor.get_commit_comments:: Exception occurred for {self.org}/{repo}: {e}")
Expand Down Expand Up @@ -957,8 +989,12 @@ def get_pr_files(self, repo, pr_number):
break
page += 1
else:
logger.error(f"GithubAPIProcessor.get_pr_files:: Error fetching files for PR #{pr_number} "
f"in {self.org}/{repo} with status_code: {response.status_code}")
if response.status_code == 403:
logger.info(f"GithubAPIProcessor.get_pr_files:: No access to files for PR #{pr_number} "
f"in {self.org}/{repo} with status_code: 403 (token lacks permission)")
else:
logger.error(f"GithubAPIProcessor.get_pr_files:: Error fetching files for PR #{pr_number} "
f"in {self.org}/{repo} with status_code: {response.status_code}")
break

return all_files
Expand Down Expand Up @@ -1001,8 +1037,12 @@ def get_pr_comments(self, repo, pr_number):
break
page += 1
else:
logger.error(f"GithubAPIProcessor.get_pr_comments:: Error fetching issue comments for PR #{pr_number} "
f"in {self.org}/{repo} with status_code: {response.status_code}")
if response.status_code == 403:
logger.info(f"GithubAPIProcessor.get_pr_comments:: No access to issue comments for PR #{pr_number} "
f"in {self.org}/{repo} with status_code: 403 (token lacks permission)")
else:
logger.error(f"GithubAPIProcessor.get_pr_comments:: Error fetching issue comments for PR #{pr_number} "
f"in {self.org}/{repo} with status_code: {response.status_code}")
break

# Get review comments (code-specific comments)
Expand All @@ -1025,8 +1065,12 @@ def get_pr_comments(self, repo, pr_number):
break
page += 1
else:
logger.error(f"GithubAPIProcessor.get_pr_comments:: Error fetching review comments for PR #{pr_number} "
f"in {self.org}/{repo} with status_code: {response.status_code}")
if response.status_code == 403:
logger.info(f"GithubAPIProcessor.get_pr_comments:: No access to review comments for PR #{pr_number} "
f"in {self.org}/{repo} with status_code: 403 (token lacks permission)")
else:
logger.error(f"GithubAPIProcessor.get_pr_comments:: Error fetching review comments for PR #{pr_number} "
f"in {self.org}/{repo} with status_code: {response.status_code}")
break

# Sort by timestamp
Expand Down