refactor: gitLab callback to improve type handling#4396
Open
watercubz wants to merge 1 commit into
Open
Conversation
the type assertion was removed; the `findGitlabById` function only accepts string type, so making an assertion causes type redundancy and reduces type safety. similarly, the case is being handled where `result.expires_in` for some reason comes out empty, null or undefined or any other type that is not the expected one, and an exception is called in the case that an unexpected value arrives.
dosubot
Bot
added
the
size:S
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is this PR about?
The type assertion was removed; the
findGitlabByIdfunction only accepts the string type, so making an assertion causes type redundancy and reduces type safety; typescript infers about the type without issue.similarly, the case is being handled where
result.expires_infor some reason comes out empty, null or undefined or any other type that is not the expected one, and an exception is called in the case that an unexpected value arrives.Checklist
Before submitting this PR, please make sure that:
canarybranch.Issues related (if applicable)
closes #4362
Screenshots (if applicable)