Skip to content

refactor: refactor addTestCommand to handle initial values#4393

Open
nahasco wants to merge 1 commit into
Dokploy:canaryfrom
nahasco:addTestCommandRefactor
Open

refactor: refactor addTestCommand to handle initial values#4393
nahasco wants to merge 1 commit into
Dokploy:canaryfrom
nahasco:addTestCommandRefactor

Conversation

@nahasco
Copy link
Copy Markdown

@nahasco nahasco commented May 12, 2026

What is this PR about?

In issue #4385 , I had to spend some time to figure out how the form UI manages and adds the test commands. This was ambiguous in the example and isnt properly explained in the docs. This simple refactor adds two strings on the first add instead of one so that the placeholders of the first two describe how the test commands form works.

Checklist

Before submitting this PR, please make sure that:

  • You created a dedicated branch based on the canary branch.
  • You have read the suggestions in the CONTRIBUTING.md file https://github.com/Dokploy/dokploy/blob/canary/CONTRIBUTING.md#pull-request
  • You have tested this PR in your local instance. If you have not tested it yet, please do so before submitting. This helps avoid wasting maintainers' time reviewing code that has not been verified by you.

Issues related (if applicable)

closes #4385

Screenshots (if applicable)

image

@nahasco nahasco requested a review from Siumauricio as a code owner May 12, 2026 18:24
@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. enhancement New feature or request labels May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Healthcheck setup is confusing

1 participant