feat: sort services in breadcrumb dropdown by user preference#4388
Open
vadamk wants to merge 1 commit into
Open
feat: sort services in breadcrumb dropdown by user preference#4388vadamk wants to merge 1 commit into
vadamk wants to merge 1 commit into
Conversation
The breadcrumb service selector now respects the same sort preference (stored in localStorage as "servicesSort") that the environment page uses. Listens for cross-tab storage events to stay in sync. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
servicesSortpreference (fromlocalStorage) that the environment page already usescreatedAtto the breadcrumb'sServiceItemtype so date-based sorting worksstorageevents to stay in sync when the user changes sort on the environment pagenew Date()allocations in the comparatorlastIndexOf("-")to safely parse sort values likelastDeploy-descContext
Currently the environment page lets users pick a sort order (name, type, createdAt, lastDeploy × asc/desc) and persists it in
localStorageunderservicesSort. But the breadcrumb's service dropdown ignores this preference and always shows services in the default extraction order. This PR makes both views consistent.Test plan
storageevent)lastDeploy-desc) works when no preference is saved🤖 Generated with Claude Code