Skip to content

fix(gitlab): use default expires_in for older GitLab versions#4387

Open
tfnick wants to merge 1 commit into
Dokploy:canaryfrom
tfnick:fix-gitlab-expired-at-nan
Open

fix(gitlab): use default expires_in for older GitLab versions#4387
tfnick wants to merge 1 commit into
Dokploy:canaryfrom
tfnick:fix-gitlab-expired-at-nan

Conversation

@tfnick
Copy link
Copy Markdown

@tfnick tfnick commented May 12, 2026

Some older GitLab versions return empty expires_in parameter during OAuth callback, causing database update errors. Now defaults to 7200 seconds (2 hours) when expires_in is not provided.

What is this PR about?

Please describe in a short paragraph what this PR is about.

Checklist

Before submitting this PR, please make sure that:

  • You created a dedicated branch based on the canary branch.
  • You have read the suggestions in the CONTRIBUTING.md file https://github.com/Dokploy/dokploy/blob/canary/CONTRIBUTING.md#pull-request
  • You have tested this PR in your local instance. If you have not tested it yet, please do so before submitting. This helps avoid wasting maintainers' time reviewing code that has not been verified by you.

Issues related (if applicable)

closes #123

Screenshots (if applicable)

Some older GitLab versions return empty expires_in parameter during
OAuth callback, causing database update errors. Now defaults to 7200
seconds (2 hours) when expires_in is not provided.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
@tfnick tfnick requested a review from Siumauricio as a code owner May 12, 2026 13:17
@dosubot dosubot Bot added size:XS This PR changes 0-9 lines, ignoring generated files. bug Something isn't working labels May 12, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working size:XS This PR changes 0-9 lines, ignoring generated files.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant