chore: migrate from release-please to semantic-release#1024
Open
scottlovegrove wants to merge 2 commits intomainfrom
Open
chore: migrate from release-please to semantic-release#1024scottlovegrove wants to merge 2 commits intomainfrom
scottlovegrove wants to merge 2 commits intomainfrom
Conversation
Replace release-please with semantic-release for automated releases, using doist/typist as the reference implementation (simplified: no `next` branch, no GitHub Packages dual publishing). Add prepublishOnly script to safeguard against broken publishes. Storybook deployment continues to work via v* tag trigger. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
After semantic-release publishes to npm, reconfigure for the GitHub Packages registry and publish there too (matching the old publish.yml). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Thank you for migrating the repository's automated versioning and publishing system from release-please to semantic-release. The changes cleanly simplify the release pipeline while preserving essential workflows like Storybook deployments and adding helpful publish safeguards. No issues were flagged during the review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
doist/typistreference implementation, simplified: nonextbranchdeploy-storybook.ymltriggers onv*tags which semantic-release creates automaticallyprepublishOnlyscript to safeguard against broken publishesChanges
release.config.js,.github/workflows/release.ymlpackage.json(added semantic-release devDeps,publishConfig.provenance,prepublishOnly),.eslintignore.github/workflows/release-please.yml,.github/workflows/publish.yml,.github/release-please-config.json,.github/release-please-manifest.jsonPre-merge checklist
.github/workflows/release.ymldoistbotapp as bypass actor on the main branch rulesetTest plan
release.ymlworkflow runs and exits cleanly (no release expected from achore:commit)feat:/fix:merge, verify: GitHub release created, npm package published to both npm and GitHub Packages, CHANGELOG.md updated, package.json version bumpedPart of https://github.com/Doist/todoist-web/issues/16941
🤖 Generated with Claude Code