Skip to content

Conversation

@frankieyan
Copy link
Member

@frankieyan frankieyan commented Jan 10, 2026

This PR sets up:

  • TypeScript
  • Biome
  • Husky + lint-staged for pre-commit hooks
  • Npm scripts:
    • check — runs all check:* scripts in parallel (using npm-run-all2)
    • check:typestsc --noEmit
    • check:biomebiome check
    • fix — runs all fix:* scripts in parallel
    • fix:biomebiome check --write
    • buildtsc
  • GitHub Actions
    • pull_request.yml — Run check, build on PRs
    • check-semantic-pull-request.yml — Enforce conventional commit PR titles

Copy link

@doist-bot doist-bot bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request establishes a solid foundation for the project's development workflow by adding linting, build scripts, and CI. The changes are generally well-implemented, but there are a few critical issues in the GitHub Actions configuration that will cause the CI to fail. I've provided suggestions to fix the invalid action versions and to simplify the caching logic, aligning it with best practices.

@frankieyan frankieyan force-pushed the frankie/lint-and-build branch from dec9351 to 58c4574 Compare January 10, 2026 04:15
@frankieyan frankieyan added the 👀 Show PR PR must be reviewed before or after merging label Jan 10, 2026
@frankieyan frankieyan requested review from a team and rmartins90 and removed request for a team January 10, 2026 04:19
@frankieyan frankieyan self-assigned this Jan 10, 2026
@frankieyan frankieyan merged commit b22fbec into main Jan 10, 2026
2 checks passed
@frankieyan frankieyan deleted the frankie/lint-and-build branch January 10, 2026 04:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

👀 Show PR PR must be reviewed before or after merging

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants