-
Notifications
You must be signed in to change notification settings - Fork 0
Landing #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: deba034ba1
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| { "src": "/", "dest": "/landing.html" }, | ||
| { "handle": "filesystem" }, | ||
| { "src": "/.*", "dest": "/index.html" } | ||
| { "src": "/.*", "dest": "/landing.html" } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ensure landing.html is emitted in the Vite build
Because the routes now rewrite all requests to /landing.html, production will depend on that file being present in the build output. The current Vite config only builds index.html (no build.rollupOptions.input for landing.html), so landing.html will not be emitted into dist and the rewrite will 404 in production unless you add it as an input or move it under public/. This breaks the landing deploy whenever the Vercel build uses Vite’s default config.
Useful? React with 👍 / 👎.
a