Bugfix: Projects from history where not loaded#200
Open
hvers wants to merge 4 commits intoDoUML:masterfrom
Open
Bugfix: Projects from history where not loaded#200hvers wants to merge 4 commits intoDoUML:masterfrom
hvers wants to merge 4 commits intoDoUML:masterfrom
Conversation
mobius3
requested changes
Apr 13, 2017
Member
mobius3
left a comment
mobius3
left a comment
There was a problem hiding this comment.
Hi! Thanks for your PR, there is some things that must be addressed before merging:
- The changes you made in the Makefile seem specific to your platform (qmake-qt5). Also the ifndef CONFIG part that you commented out must be uncommented.
- The .directory and douml.kdev4 files don't belong to the source.
- The src/diagram/UmlWindow.cpp needs cleanup (remove commented code)
After these changes it can be merged.
Thanks again!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.