fix(adapter-anthropic): flush trailing SSE buffer on stream close#7
Open
DizzyMii wants to merge 1 commit into
Open
fix(adapter-anthropic): flush trailing SSE buffer on stream close#7DizzyMii wants to merge 1 commit into
DizzyMii wants to merge 1 commit into
Conversation
parseSSE only emitted events split on a blank line, so a final event such as message_stop that is not followed by a trailing "\n\n" was left in the buffer and dropped, so the terminal usage/end chunks were never yielded. Flush the remaining buffer after the read loop, matching the OpenAI-compat adapter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@
The Anthropic adapters
parseSSEonly emitted events split on\n\n, keeping the trailing fragment in a buffer between reads. When the stream closed, that buffer was never flushed — so a final event (e.g.message_stop) not terminated by a blank line was silently dropped.Because the terminal
usageandendchunks are emitted only onmessage_stop, dropping it leaves the stream without a proper completion signal. The OpenAI-compat adapter already flushes its buffer on close; this brings the Anthropic adapter in line.Verification
pnpm --filter @flint/adapter-anthropic typecheck✓pnpm --filter @flint/adapter-anthropic test✓ (26 tests, incl. a new case where the finalmessage_stophas no trailing blank line and theendchunk must still be emitted)biome lintclean on changed files@