Skip to content

Don't serialize URL arguments so worker knows to fetch them as remote URLs #35

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
YarnSaw merged 1 commit into from
Mar 25, 2025
Merged

Don't serialize URL arguments so worker knows to fetch them as remote URLs #35

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions dcp/api/job.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,9 @@ def _before_exec(self, *args, **kwargs):
# un-hide values from PythonMonkey which aren't supported
if isinstance(argument, dict) and '__pythonmonkey_guard' in argument:
argument = argument['__pythonmonkey_guard']
if utils.instanceof(argument, pm.eval("URL")):
serialized_arguments.append(argument)
continue

serialized_argument = serialize(argument, self.serializers)
serialized_arguments.append(serialized_argument)
Expand Down